Skip to content

Add codspeed<>divan compat layer #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 6, 2025
Merged

Add codspeed<>divan compat layer #65

merged 3 commits into from
Feb 6, 2025

Conversation

@GuillaumeLagrange
Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange commented Jan 30, 2025 •
edited
Loading

Currently implemented

  • Simple bench using #[divan::bench]
  • Basic argument handler for divan::bench macro
  • Argument generator .with_inputs()

TODO before first release

  • Automated tests
  • Support for all arguments at least in a non compilation breaking way

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 30, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #65 will not alter performance

Comparing cod-362-add-a-divan-shim (d525802) with main (a65176f)

Summary

✅ 54 untouched benchmarks

art049
art049 reviewed Jan 31, 2025
View reviewed changes
Copy link
Member

@art049 art049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty cool overall and seem much more simple than for our other integration! let's go 💪

art049
art049 reviewed Feb 5, 2025
View reviewed changes
Copy link
Member

@art049 art049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to run those new benches in the ci workflow before merging

@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-362-add-a-divan-shim branch 3 times, most recently from 682d7af to 8104c13 Compare February 6, 2025 13:26
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 6, 2025 •
edited
Loading

CodSpeed Walltime Performance Report

Merging #65 will not alter performance

Comparing cod-362-add-a-divan-shim (d525802) with main (a65176f)

Summary

✅ 1 untouched benchmarks
🆕 1 new benchmarks
⁉️ 1 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 fibo_10 N/A 3.6 µs N/A
⁉️ fibo_100 3.6 µs N/A N/A

@GuillaumeLagrange GuillaumeLagrange marked this pull request as ready for review February 6, 2025 13:33
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-362-add-a-divan-shim branch 2 times, most recently from 02ab31a to 055d0f9 Compare February 6, 2025 14:06
art049
art049 approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@art049 art049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀
As discused, can you undo the reformating of the doctest in the divan fork's doctests?

@GuillaumeLagrange GuillaumeLagrange merged commit d525802 into main Feb 6, 2025
6 checks passed
@GuillaumeLagrange GuillaumeLagrange deleted the cod-362-add-a-divan-shim branch February 6, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@art049 art049 art049 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GuillaumeLagrange @art049